Add createTheme helper function to enforce proper shape for user themes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Could you update the examples in the readme to use this function as well? |
This allows users to enforce their themes to have the same shape as the BaseTheme, but
it retains the types of the users specific values (e.g. what colors the theme has) and also
prevents the loss of typesafety from the `{ [key:string]: any }` in BaseTheme
|
@JoelBesada done |
META-DREAMER
force-pushed
the
createTheme
branch
from
8a7dffa to
311891b
Compare
|
@HammadJ Thanks! |
META-DREAMER
added a commit
to META-DREAMER/restyle
that referenced
this pull request
Jul 22, 2020
…es (Shopify#18) * Add createTheme helper function to enforce proper shape for user themes This allows users to enforce their themes to have the same shape as the BaseTheme, but it retains the types of the users specific values (e.g. what colors the theme has) and also prevents the loss of typesafety from the `{ [key:string]: any }` in BaseTheme * Update README with usage of createTheme helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to enforce their themes to have the same shape as the BaseTheme, but
it retains the types of the users specific values (e.g. what colors the theme has) and also
prevents the loss of typesafety from the
{ [key:string]: any }in BaseTheme